BitcoinDesign / Guide

A free, open-source community resource for designers, developers and others working on non-custodial bitcoin products.
https://bitcoin.design/guide/
Other
457 stars 98 forks source link

Describe PSBT as portable data format #1001

Closed DanGould closed 1 year ago

DanGould commented 1 year ago

Yes, PSBT was born to solve the multisig problem, but now, especially after PSBT2, its use has expanded to facilitate all types of interactive transactions.

I'd rather see it described as a data format or a bitcoin standard than a file format. The situations where psbt are serialized to a file system represent only a fraction of their use.

It may help to explain that, in contrast to PSBT, a consensus Transaction only has data necessary to perform validation, including only references to look up to inputs earlier in the blockchain. While a PSBT may have complete input information rather than just those reference pointers.

I see PSBTs as scaffolding with which interactive parties may come to agree on a consensus transaction to broadcast.

netlify[bot] commented 1 year ago

Deploy Preview for bitcoin-design-site ready!

Name Link
Latest commit b5b4cf99c45ded0be80c5681430d3afa29ea86e8
Latest deploy log https://app.netlify.com/sites/bitcoin-design-site/deploys/644fa8197cfce90007ad4b29
Deploy Preview https://deploy-preview-1001--bitcoin-design-site.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

yashrajd commented 1 year ago

My view is that a distinction be made between the format and its instantiation (thanks @DanGould for this word), though they are referred by the same name. The current definition only defines PSBT as a format, but data/file in the PSBT format is routinely referred to as a PSBT.

This is far from the only instance where such a confusion arises. eg: "monkey jpegs"

In many (probably majority) situations we're talking about an individual transaction in the format prescribed by BIP-174. A great example of this is BIP-78

GBKS commented 1 year ago

Is this ready for final review or are you still working on changes based on the unresolved conversation?

yashrajd commented 1 year ago

@DanGould it'd be great to have this ready for final review.

edit: spoke to Dan and can't get to it right now. I can create a new PR if this is urgent.

DanGould commented 1 year ago

Revised based on feedback

ready for review

DanGould commented 1 year ago

ready ✨