BitcoinDesign / Guide

A free, open-source community resource for designers, developers and others working on non-custodial bitcoin products.
https://bitcoin.design/guide/
Other
455 stars 98 forks source link

Inheritance wallet - Part 1 #1081

Closed rabbitholiness closed 4 months ago

rabbitholiness commented 8 months ago

This multi-page reference design looks at a multi-key wallet for family savings. It includes a recovery path as well as a timelocked inheritance key set. Apart from wallet creation, the reference design also addresses topics like wallet backups, key rotation and recovery.

This PR addresses the first part of the series, which will cover the landing page, the use case description and the wallet creation flow. The outline of the entire reference design is described on the landing page and marked as "coming soon". The remaining pages will be added step by step.

👉 Preview it here 👈

netlify[bot] commented 8 months ago

Deploy Preview for bitcoin-design-site ready!

Name Link
Latest commit ceedadff3d466d6e16e0a438700983986c2d8a4c
Latest deploy log https://app.netlify.com/sites/bitcoin-design-site/deploys/6682bc898617ce00085ae25f
Deploy Preview https://deploy-preview-1081--bitcoin-design-site.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rabbitholiness commented 7 months ago

I'm taking the PR out of draft mode to gather initial feedback. I'll be adding at least one clickable prototype for the wallet creation page by Thursday.

mouxdesign commented 7 months ago

Just reviewed the wallet creation page, looks great, really like how vibrant and friendly the designs look.

Some ideas: The user flow itself is split into 3 distinct sections, each of those having subsections under each. As a builder landing on this page the flow is pretty detailed. To manage the expectations of the builder, if they commit to building this out in their wallet then how much of complexity would it require. See that there is a high level menu at the top which allows the reader to navigate however that would be more to navigate the content. A higher level overview could help with this in the beginning, this can be an image or text setting expectations:

Step1: First configure wallet

  1. Primary keyset (add keys)
  2. Create recovery path
  3. Create dedicated inheritance keyset Are any of these steps optional?

Step 2: Add signing keys

  1. Primary
  2. Inheritance keys

Step 3: Finalize the wallet

Spelling: there was one small typo on one of the screen designs: Screenshot 2024-04-22 135736 Custom "answer a couple of questions"

Other than that the language on the page is nice and easy to understand, you did a really great job of that considering how complex this topic is.

rabbitholiness commented 7 months ago

Just pushed a quite extensive update. Here's the TL;DR:

Use case & scope page:

Wallet creation page:

rabbitholiness commented 5 months ago

Looks really good. Just had a few minor comments.

I also recommend running the images through a compression tool like ImageOptim. You can cut the file size by 50-80%.

In the wallet creation page, I think the file coming-soon-placeholder.png is not used anymore. Most likely you have more unused images in there. You use 56 visuals in image galleries, which means 112 images. Then there are 4 images for the prototype, for a total of 116. But the wallet creation folder includes 129 images. Maybe another 12 unused ones in there?

Should all be addressed now. Took some digging but I found the superfluous images :-)

rabbitholiness commented 4 months ago

@GBKS do you think we can get this one merged?

mouxdesign commented 4 months ago

Looks good to fly Michael.

One small comment is that the icon for the wallet backup is not showing up on my screen.

Screenshot 2024-07-01 111709