BitcoinDesign / Guide

A free, open-source community resource for designers, developers and others working on non-custodial bitcoin products.
https://bitcoin.design/guide/
Other
455 stars 96 forks source link

Move 'Foundations' section higher up on menu #257

Closed Bosch-0 closed 3 years ago

Bosch-0 commented 3 years ago

Would it not make sense to include the foundations closer to the start of the Guide? If somewhere were to read from start to finish, laying out the foundations first makes the other sections of the Guide make more sense.

When reviewing the create a wallet page for on boarding today I couldn't help but think 'what kind of wallet' are we creating. It mentions selfy-custody wallets but had I read the foundations first things would of pieced together nicely in my mind. Maybe include it after Getting started like below:

Group 201

GBKS commented 3 years ago

Make sense to me.

danielnordh commented 3 years ago

The contents of Foundations is currently just

Moving Principles up on it's own makes sense in my view as it is a good primer for how we have approached the guide. That leaves Foundations rather empty, but I wouldn't worry to much about that now as it's always been more of an 'appendix' or grab bag that doesn't fit elsewhere.

Bosch-0 commented 3 years ago

Just a suggestion but the principles page makes more sense being in the 'Getting started' chapter and the wallet interoperability page could be removed and we just make sure that this concept is discussed in the relevant sections of the guide.

For example, the multi signature wallet content in wallet interoperability could be intertwined into the multi-key page in PKM chapter.

GBKS commented 3 years ago

Is this still relevant with the comments around moving the foundations pages to the new "Designing Bitcoin products" section?

danielnordh commented 3 years ago

I could see the Principles fitting early into 'Designing Bitcoin products'. Thoughts?

Bosch-0 commented 3 years ago

I could see the Principles fitting early into 'Designing Bitcoin products'. Thoughts?

Yep I agree. Was going to open a PR moving principles / wallet interoperability into designing bitcoin products. Will close this after that.

GBKS commented 3 years ago

Created PR #346 for this. Check the preview.