search

BitcoinDesign / Guide

A free, open-source community resource for designers, developers and others working on non-custodial bitcoin products.
https://bitcoin.design/guide/
Other
457 stars 98 forks source link

Add a `/social-media` page to the site #977

Closed GBKS closed 1 year ago

GBKS commented 1 year ago

A very similar PR to #967, and implementing #968, this PR adds a page about the community's social media accounts to the website.

The new page in the main nav as "Follow". The term "Social media" was too long, and we may be branching out to Nostr very soon as well so it won't be just Twitter. Do we even need this in the main nav? Or is it enough to link to it from the home and contribute pages?

🚌Check the preview🚐

Addresses #968

netlify[bot] commented 1 year ago

Deploy Preview for bitcoin-design-site ready!

Name Link
Latest commit 8d17b5fd624588af39bc4d08dd557a5ce2401379
Latest deploy log https://app.netlify.com/sites/bitcoin-design-site/deploys/63d8f177f2aebd00091d3de3
Deploy Preview https://deploy-preview-977--bitcoin-design-site.netlify.app/guide/contribute/formatting/media
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mouxdesign commented 1 year ago

LGTM.

Added some very minor suggestions to the text itself, mainly just small items like punctuation and headings. Other than that it looks great.

Google doc with minor comments

GBKS commented 1 year ago

Thanks for the feedback, I just made (most of) the changes. Also resolved the conflict with the image compression cache file. Ready for another round of review.

mouxdesign commented 1 year ago

Reviewed and LGTM

sbddesign commented 1 year ago

Merging because I see Mo left a written approval in the comment above, so that's 2 approvals now.