search

BitcoinDesign / Guide

A free, open-source community resource for designers, developers and others working on non-custodial bitcoin products.
https://bitcoin.design/guide/
Other
457 stars 98 forks source link

Payjoin case study #993

Closed yashrajd closed 1 year ago

yashrajd commented 1 year ago

99% done. Ready for final review.

edit: 💻 Deploy preview

netlify[bot] commented 1 year ago

Deploy Preview for bitcoin-design-site ready!

Name Link
Latest commit 7f657e615c02ec932d721965ab2caac4844acb47
Latest deploy log https://app.netlify.com/sites/bitcoin-design-site/deploys/642be838773cab0008f9c893
Deploy Preview https://deploy-preview-993--bitcoin-design-site.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

GBKS commented 1 year ago

Just a heads-up, for the screens, you can use the image gallery to show the full-sized mock-ups in a horizontal slider, like here.

yashrajd commented 1 year ago

Just a heads-up, for the screens, you can use the image gallery to show the full-sized mock-ups in a horizontal slider, like here.

It does look great, Stephen suggested it as well. Will do.

sbddesign commented 1 year ago

@yashrajd and I have been jamming on header images. We have some rough draft ideas. Looking for some opinions on these ideas, then we can actually clean up one of these and make it work as a header. Or suggest ideas if you have them.

Concept: cyberpunks making a secret transaction in a dark alley

header-cyberpunk-transaction

Concept: a handshake between two characters (payjoins are a collaborative process)

header-handshake

Concept: try to make some visual graphical metaphors for privacy, how payjoins obfuscate things, etc

header-graphic-metaphor

Concept: show Bob shopping for Alice's wedding ring

header-bob-buying-ring

yashrajd commented 1 year ago
image gallery
GBKS commented 1 year ago

@sbddesign @yashrajd great explorations for the header images. I'd recommend staying away from anything that implies secrecy, fear, having things to hide or even illegal activity (dark alley, guy in trench coat checking to see if he's being followed). Privacy should be a natural default for everyone. So I Iike the handshake one better. I also like the idea of the third one, where someone tries to snoop and just can't figure things out. Maybe those could be mashed up? Two people shaking hands with some visual of a transaction arising from that, and then there being tons of transactions around it that look identical. If it's too much to pack into an image, maybe consider that the page title and image are typically seen together each each one could communicate one aspect of what you want to express.

GBKS commented 1 year ago

@DanGould noted your point about merging with the expectation of revisions, it's a good way to go about things. @yashrajd, this is totally up to you. The PR status is draft, and your top comment states it is not ready, so I have not done a detailed review yet. Feel free to update that whenever works for you.

yashrajd commented 1 year ago

Updated top comment, please feel free to do a detailed review @GBKS or anybody else reading this comment.

mouxdesign commented 1 year ago

Really like the headings you guys came up with!

Some minor suggestions to text from my side. Other than that, looks good! Nicely done!

Introduction:

Text: However, real time coordination between the sender & receiver mediated through an endpoint is required to construct them. Suggestion: Real time coordination between the sender & receiver mediated through an endpoint is required to construct them.

Text: Proposes specific user flows and where possible, working designs for the same. Suggestion: Proposes specific user flows and where possible as well as design solutions.

Our Approach

Text: This case study follows these tentative steps: Suggestion: This case study follows these steps:

Text: sender and receiver of a payment Suggestion: Sender and receiver of a payment

Proposed Receiver Flow

Text: Here we will devise user flows for a POS system that can always be online. This excludes mobile wallets. Suggestion: We will created a user flows for a POS system that can always be online. This excludes mobile wallets.

New Horizons

Text: This case study not only tackles the design aspects around Payjoin, it hopes to boost interest in the various use cases and benefits. Suggestion: This case study tackles the design aspects around Payjoin and it hopes to boost interest in it's various use cases and benefits.

yashrajd commented 1 year ago

Really like the headings you guys came up with!

Some minor suggestions to text from my side. Other than that, looks good! Nicely done!

Thank you, I appreciate the time and detailed reading put into this!

Introduction:

Text: However, real time coordination between the sender & receiver mediated through an endpoint is required to construct them. Suggestion: Real time coordination between the sender & receiver mediated through an endpoint is required to construct them.

Both the requirements, namely "real time coordination" and "an endpoint" places constraints on the UX, which is why I used "however".

Text: Proposes specific user flows and where possible, working designs for the same. Suggestion: Proposes specific user flows and where possible as well as design solutions.

Not sure what you mean...

Our Approach

Text: This case study follows these tentative steps: Suggestion: This case study follows these steps:

Makes sense. I think Christoph pointed this out too, so believe I have addressed it. Text: sender and receiver of a payment Suggestion: Sender and receiver of a payment

Proposed Receiver Flow

Text: Here we will devise user flows for a POS system that can always be online. This excludes mobile wallets. Suggestion: We will created a user flows for a POS system that can always be online. This excludes mobile wallets.

I used 'devise' to indicate thought and intention went into it and not simply created from vacuum.

New Horizons

Text: This case study not only tackles the design aspects around Payjoin, it hopes to boost interest in the various use cases and benefits. Suggestion: This case study tackles the design aspects around Payjoin and it hopes to boost interest in it's various use cases and benefits.

This is definitely an improvement. Incorporated!

yashrajd commented 1 year ago

Ready to merge if all looks good.

GBKS commented 1 year ago

@yashrajd thanks for patiently addressing all my nitpicks. I think the case study look great and is ready to go, I'm happy to approve and merge now, you just need to resolve the conflict with the _compress_images_cache.yml file. Let me know if you'd like help with that.

yashrajd commented 1 year ago

@yashrajd thanks for patiently addressing all my nitpicks. I think the case study look great and is ready to go, I'm happy to approve and merge now, you just need to resolve the conflict with the _compress_images_cache.yml file. Let me know if you'd like help with that.

That's great, would love to help resolve the conflict. Looks like my branch is missing the images from the PIN reminders PR?