BitcoinMafia / SpareCoinsExt

Bitcoin Wallet Chrome Extension
www.sparecoins.io
MIT License
34 stars 11 forks source link

CRITICAL BUG #5

Closed cilphex closed 10 years ago

cilphex commented 10 years ago

Uncaught Error: [object Object]

chrome-extension://nhkolgoaflkjhfkamdhiahingnendokj/js/app.js

36

cilphex commented 10 years ago

I got this once, and now every subsequent time I open the extension, it shows the UI for a split second, then shows this error again.

scottlingran commented 10 years ago

@sidazhang Looks like BitcoinNodeAPI.multiAddr is throwing an error on callback. Makes sense given cliphex is seeing the UI for a split second.

BitcoinNodeAPI.multiAddr throws an error only when the Bitcoin addresses are malformed.

@cilphex, is anything else logging in the console?

sidazhang commented 10 years ago

@locksley uncaught error [object Object], you sure its because the address is malformed?

If this is an issue that happens every now and then it could be an issue with blockchain API. They occasionally return an error.

I haven't personally seen this yet though.

scottlingran commented 10 years ago

@cilphex, pretty sure this was a network error issue, was your computer offline or patchy wifi? Just deployed the fix on Chrome Store, v1.0.11

Let us know if it's still a problem.

cilphex commented 10 years ago

It gave me a new address and the bitcoin I sent to the first one is apparently just lost.

On Thu, Dec 12, 2013 at 9:56 PM, Scott Li notifications@github.com wrote:

@cilphex https://github.com/cilphex, pretty sure this was a network error issue. Just deployed the fix on Chrome Store, v1.0.11

Let us know if it's still a problem.

— Reply to this email directly or view it on GitHubhttps://github.com/BitcoinMafia/SpareCoinsExt/issues/5#issuecomment-30488727 .

scottlingran commented 10 years ago

What do you mean lost? Are you sure you can't see the other address in "History" or "See All Addresses?"

Addresses are stored in Chrome Storage and should never be cleared unless you do chrome.storage.local.clear() in console.

cilphex commented 10 years ago

I only see one transaction in History, whcih is a new transaction from today. The address I sent to doesn't appear under All Addresses. Maybe it was another computer, not sure. But I thought this synced across my Chromes, maybe it doesn't?

On Fri, Dec 13, 2013 at 2:16 AM, Scott Li notifications@github.com wrote:

What do you mean lost? Are you sure you can't see the other address in "History" or "See All Addresses?"

Addresses are stored in Chrome Storage and should never be cleared unless you do chrome.storage.local.clear() in console.

— Reply to this email directly or view it on GitHubhttps://github.com/BitcoinMafia/SpareCoinsExt/issues/5#issuecomment-30499005 .

sidazhang commented 10 years ago

@cilphex hey, its not currently synced across your chromes. All keys are stored locally in each browser. So unfortunately, at this stage you would have to move funds between browsers.

This is a decision we made after a few people expressed concerns about their encrypted keys being synced.

I personally think it would be far more convenient to have them synced. Out of curiosity, how comfortable are you with syncing your encrypted keys? Do you think it might be a good feature to have?

sidazhang commented 10 years ago

@cilphex do you still have the same issues? If not, I will close this ticket