search

BitcoinQnA / seedtool

GNU General Public License v3.0
74 stars 16 forks source link

TapRoot (P2TR) address in Single Address Tool section #51

Closed GregTonoski closed 1 year ago

GregTonoski commented 1 year ago

As a user, I want a TapRoot type of address to be show (alongside "legacy", "wrapped segwit" and "native segwit') so that I can learn all the of them in one place. (I suggest showing the raw TapRoot address generated from an "internal" a.k.a. "untweaked" public key: bc1pgrulsvazt3e9gqhzg2t9gy94hwvjm3875yegdq0s5azhrscsfcmqgk5wqt in the case shown in the image below).

image

Jones098 commented 1 year ago

As a user, I want a TapRoot type of address to be show (alongside "legacy", "wrapped segwit" and "native segwit') so that I can learn all the of them in one place. (I suggest showing the raw TapRoot address generated from an "internal" a.k.a. "untweaked" public key).

image

Thanks 🙏

SuperPhatArrow commented 1 year ago

Hi,

Sorry it is not included, this definitely should have been part of this feature when it was released since we already had P2TR in the tool at that point.

I will add it ASAP and include it in the next update.

Thanks for bring this to my attention.

SuperPhatArrow commented 1 year ago

I believe this is now added:

image

If everyone is happy we can merge into main to be included in the next release and close this issue.

SuperPhatArrow commented 1 year ago

@GregTonoski can you confirm that the above screenshot was what you requested here, please? I don't want to just close it if I misunderstood you in some way.

GregTonoski commented 1 year ago

I confirm that the screenshots includes what was requested. Thank you.