Closed AndrewClifford closed 6 years ago
I agree entirely and I think this is a worthy change to do.
Going to implement it.
On Tue, Apr 24, 2018 at 10:04 AM, Andrew Clifford notifications@github.com wrote:
User-agent substrings can be variable depending upon user configuration. I suggest truncating at the first parenthesis "(" when counting different implementations for the top ten, otherwise the raw total is a very prominent number and can be misleading. For example, the search function reveals 40 instances of BUCash:1.3, however only 27 are shown in the top ten count because they have EB values different from the most frequent, which is the default.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BitcoinUnlimited/cashnodes-frontend/issues/24, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZrE5sNx79ZSt-IqX7H1RyqUBmA5KPUks5trtyRgaJpZM4ThL_D .
done, see #25
already deployed
Fast work and looks really good! A much cleaner list.
I'm glad you appreciate it.
Closing due to #25
The top ten are prominent numbers for viewers. However, user-agent subversions can be variable depending upon user configuration, and this can make the raw totals misleading. For example, the search function reveals 40 instances of BUCash:1.3, when only 27 are shown in the top ten count because they have EB values different from the most frequent, which is the default. I suggest truncating at the first parenthesis "(" when counting different implementations for the top ten. Not sure whether the names should be truncated, or the most common subversion shown.