search

BitcreditProtocol / E-Bill

Core for Bitcredit project.
https://www.bit.cr/
MIT License
12 stars 2 forks source link

154 cleanup and small improvements collection task #196

Closed zupzup closed 3 weeks ago

zupzup commented 3 weeks ago

This fixes the list of small improvements in https://github.com/BitcreditProtocol/E-Bill/issues/154 (some where already fixed within other tasks).

The most important parts are around async handling (removed the block_on calls), as well as path-building.

Also, usages of thread::spawn and tokio::main (beyond main.rs) were documented to be replaced soon with the new mint.

zupzup commented 3 weeks ago

For all the storage file paths it would be great to consolidate them into some configurable base path at some point, so we can mount a non ephermal volume as data dir into the docker container.

Overal LGTM given the multiple runtimes are already scheduled for a rework.

Good point about the storage file paths - created a ticket in the backlog https://github.com/BitcreditProtocol/E-Bill/issues/197