Closed zupzup closed 1 week ago
Attention: Patch coverage is 53.06799%
with 566 lines
in your changes missing coverage. Please review.
Project coverage is 14.44%. Comparing base (
be86fb9
) to head (114defe
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
LGTM
Wow this one is quite massive. I can not really follow how the file upload stuff works just from the diffs but impl. looks fine. The rest of the refactoring also looks very good (as already mentioned). A bit small chunks might be easier to chew 😁
Yes, you're absolutely right, this escalated a bit :see_no_evil: - sorry! And in retrospect it seems a lot clearer, where there might have been good lines to split this by and I'll take care to keep things smaller, also for my own sanity's sake. :sweat_smile:
This will become easier with more structure as well, as it's already easier to spot which parts of the system will have to be touched by a certain change with the changes we already did. :+1:
This fixes #115 and adds the functionality for uploading files when issueing a bill, as well as to locally view these uploaded files.
Notes
bill
file format, so any previously saved bill will be invalid from merging this onward and will likely panic the appBesides that, I restructured a few things and added tests where possible and transitioned the contacts API to use
tokio::fs
, as to not block on the async runtime.