BitcreditProtocol / E-Bill

Core for Bitcredit project.
https://www.bit.cr/
MIT License
12 stars 2 forks source link

Nostr processing #220

Closed tompro closed 3 days ago

tompro commented 1 week ago

Looking for ways to test Nostr private messages I found out that yes we have the latest cool shit (NIP17 private messaging) but most prominent relays out in the wild do not support this yet (there are a few paid ones that already do). It could be that for a while we have to run our own to make E2E manual testing easier in BE and FE.

tompro commented 3 days ago

@mtbitcr yes I was thinking about a relay list as well. For DMs in Nostr you should always send to the Inbox relay where you usually have a single one configured (but could be multiple). I chose to use a single one just bcs it is way simpler to keep in sync in the contacts when we pull them P2P. We can still switch it to a relay list later if we discover it is necessary :thinking: .

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 73.91304% with 36 lines in your changes missing coverage. Please review.

Project coverage is 18.32%. Comparing base (93ded80) to head (ac00d12). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/service/notification_service/nostr.rs 80.76% 20 Missing :warning:
src/persistence/contact.rs 0.00% 9 Missing :warning:
src/service/contact_service.rs 50.00% 4 Missing :warning:
src/blockchain/chain.rs 0.00% 1 Missing :warning:
src/service/identity_service.rs 66.66% 1 Missing :warning:
src/service/notification_service/email.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #220 +/- ## ========================================== + Coverage 16.75% 18.32% +1.57% ========================================== Files 45 46 +1 Lines 9086 9218 +132 ========================================== + Hits 1522 1689 +167 + Misses 7564 7529 -35 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: