BitcreditProtocol / E-Bill

Core for Bitcredit project.
https://www.bit.cr/
MIT License
12 stars 2 forks source link

214 refactor bills #224

Closed zupzup closed 3 days ago

zupzup commented 4 days ago

The bill-refactoring part of #214, moving most of the logic for bill to the service/persistence structure and adding testability and error-handling across the code base.

Structurally, it's mostly done - I'll take a look at the long return_bill handler and see, if I can't move parts of it into the service and reduce some duplication there.

Besides that, I'll just add tests for most of the bill service methods, as far as that's possible before the blockchain code refactoring.

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 72.04451% with 402 lines in your changes missing coverage. Please review.

Project coverage is 31.88%. Comparing base (6122f09) to head (8c0d384). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/web/handlers/bill.rs 0.00% 151 Missing :warning:
src/service/bill_service.rs 87.26% 145 Missing :warning:
src/persistence/bill.rs 0.00% 54 Missing :warning:
src/dht/client.rs 0.00% 16 Missing :warning:
src/util/file.rs 0.00% 14 Missing :warning:
src/service/mod.rs 0.00% 12 Missing :warning:
src/blockchain/chain.rs 72.22% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #224 +/- ## =========================================== + Coverage 18.32% 31.88% +13.56% =========================================== Files 46 46 Lines 9218 9831 +613 =========================================== + Hits 1689 3135 +1446 + Misses 7529 6696 -833 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: