search

BiteKollektiv / webcal

Anonymous web calendars as a service
GNU General Public License v3.0
2 stars 1 forks source link

Delete calendar export files from server after download #46

Closed vaxr closed 10 years ago

vaxr commented 10 years ago

Issue #43

phansch commented 10 years ago

Thanks for working on this! Things are looking fine. It seems there are some problems with the Travis build, which are not related to your changes. Will take a look at this possibly later today.

phansch commented 10 years ago

Hey @vaxr, just a quick update on the failing build situation. We figured out what the problem with the build is, but it will not be fixed today. This will take a bit longer, since every external pull request will have the same problem. So this requires some thought first.

Travis has some restrictions on secure environment variables, which currently prevents all external pull requests from runnig properly. (There's more information here if you're interested)

vaxr commented 10 years ago

Thanks @phansch . Maybe you could add me to the BatchZero group so I can push commits directly?

phansch commented 10 years ago

Hey @vaxr,

the build issues are fixed now. In order to make the build for this pull request pass, you will have to get the latest changes from upstream first. Then you will have to merge them into your fork and update the pull request again. If you need help with that just let us know.

I also added you to the organization, so you can now push commits directly. If you start working on an issue, it's best to let us know by leaving a comment on the issue. Also, please make sure you have read our conventions.

vaxr commented 10 years ago

Updated pull request. Sorry for the long silence. Thanks for adding me to the group BTW, although it seems I still don't have write access to this repo.

phansch commented 10 years ago

Thanks for the update! I will take a look later today, since I'm a bit out of touch with the webcal :)