Feature/functional tests updates segwit p2p ibd txrelay rpc getblockfrompeer p2p addconnections

[gitcoindev]

Description

Hi @wu-emma, @van-orton I am back -) I hope the project is still alive. Had issues with integration back and forth but finally had a breakthrough. This pull request initially was to tackle only segwit test but brings cherry-picked improvements from Bitcoin core integrated to Bitgesell:

• speed up of test execution and enabling mocked time for functional tests
• extended test/functional/p2p_ibd_txrelay.py
• added rpc getblockfrompeer() and related test case test/functional/rpc_getblockfrompeer.py
• removed feature_segwit and feature_nulldumy from default test executions as both test cases are related to segwit, which in Bitgesell is enabled from the genesis block
• fixed p2p_add_connections.py test case

Just one functional test case rpc_packages.py is failing now, and wallet_importdescriptors.py is shaky, mostly passing when running standalone but fails with full test suite on importing the same descriptor with private key twice, both to be investigated.

[wu-emma]

@gitcoindev thanks for participation! Hi @janus could you please take a look at this PR? ping @van-orton

[janus]

@gitcoindev thanks for participation! Hi @janus could you please take a look at this PR? ping @van-orton

Alright.

[janus]

@gitcoindev Did you try with clang? Something like below ./configure CXX=clang++ CC=clang --with-incompatible-bdb

[janus]

@gitcoindev I noticed that you committed some pretty new commits from bitcoin. Is it possible to work with this branch, https://github.com/BitgesellOfficial/bitgesell/tree/bitcoinsync2022? It is updated to 2022.

[gitcoindev]

Hi @janus thank you for checking, I can try to rebase to https://github.com/BitgesellOfficial/bitgesell/tree/bitcoinsync2022 , could you please provide the exact commands that you use to build your 2022 branch so that I have the same setup as yours?

wt., 20 cze 2023 o 11:20 Emeka @.***> napisał(a):

@gitcoindev https://github.com/gitcoindev I noticed that you committed some pretty new commits from bitcoin. Is it possible to work with this branch, https://github.com/BitgesellOfficial/bitgesell/tree/bitcoinsync2022? It is updated to 2022.

— Reply to this email directly, view it on GitHub https://github.com/BitgesellOfficial/bitgesell/pull/124#issuecomment-1598421279, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVFGLNPLTNMMYVJWILYZSSDXMFTO5ANCNFSM6AAAAAAZJA5TAM . You are receiving this because you were mentioned.Message ID: @.***>

[janus]

Hi @janus thank you for checking, I can try to rebase to https://github.com/BitgesellOfficial/bitgesell/tree/bitcoinsync2022 , could you please provide the exact commands that you use to build your 2022 branch so that I have the same setup as yours? wt., 20 cze 2023 o 11:20 Emeka @.> napisał(a): … @gitcoindev https://github.com/gitcoindev I noticed that you committed some pretty new commits from bitcoin. Is it possible to work with this branch, https://github.com/BitgesellOfficial/bitgesell/tree/bitcoinsync2022? It is updated to 2022. — Reply to this email directly, view it on GitHub <#124 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVFGLNPLTNMMYVJWILYZSSDXMFTO5ANCNFSM6AAAAAAZJA5TAM . You are receiving this because you were mentioned.Message ID: @.>

Please I would prefer if you work on branch bitcoinsync2022. It has around 4% unit tests that are failing and about 20% integration tests that are still failing. Don't use commits that are younger than 31st December, 2022.

It should be able to work with any configuration setting.

[gitcoindev]

This will take a while as I am having compilation issues and need to figure out the root cause. I will reopen when it's ready.

[gitcoindev]

Hi @janus I was able to build as well this PR with clang - just had to use newer clang 14 and not the default clang for Ubuntu 20.04 using the following steps.

$ wget https://apt.llvm.org/llvm.sh
$ chmod +x ./llvm.sh 
$ sudo ./llvm.sh 14
$ ./configure --with-incompatible-bdb --enable-suppress-external-warnings CC=clang-14 CCX=clang++-14
$ make clean
$ make -j16

Feel free to merge this one or reject the PR to master. I will also try to cherry pick to bitcoin2022 branch with commits younger than 31st December, 2022 (might take me until Friday).

[naftalimurgor]

Hey @gitcoindev

This is great, it would be great to have this work for both Clang 14+ and GCC. Also, the bitcoinsync2022 branch has a lot of commits that are synced from Bitcoin Core

[janus]

Hi @janus I was able to build as well this PR with clang - just had to use newer clang 14 and not the default clang for Ubuntu 20.04 using the following steps.

$ wget https://apt.llvm.org/llvm.sh
$ chmod +x ./llvm.sh 
$ sudo ./llvm.sh 14
$ ./configure --with-incompatible-bdb --enable-suppress-external-warnings CC=clang-14 CCX=clang++-14
$ make clean
$ make -j16

Feel free to merge this one or reject the PR to master. I will also try to cherry pick to bitcoin2022 branch with commits younger than 31st December, 2022 (might take me until Friday).

Great! We are in the process of updating master branch, I would prefer if you continue working on bitcoinsync2022 failing tests. However, we may cherry-pick from that PR in the future.