Completely remove old (non-segwit) transaction support

BitgesellOfficial / bitgesell

Bitgesell (BGL) is a digital currency with built-in scarcity

https://www.bitgesell.ca

MIT License

23 stars 37 forks source link

Completely remove old (non-segwit) transaction support #16

Open van-orton opened 3 years ago

van-orton commented 3 years ago

Problem description

The code of BGL core is derived from Bitcoin core with some changes. The BTC is switching gradually to segwit transactions, while allowing older txs and addresses to still work. In BGL, those legacy transactions are not required. In other words, remove support for P2PK[H] to be sure no 'old' transaction can be made, and leave only SegWit transactions supported.

Solution direction

carefully check in source code where transaction types are detected or formed;
remove support for legacy transaction types where applicable;
tread lightly, don't remove something if unsure;

Acceptance criteria

Old transaction types cannot be created though CLI/wallet, validated, etc.

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 1.0419 ETH (400.01 USD @ $383.93/ETH) attached to it.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Chat
- $906,413.11 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 266 years, 1 month from now. Please review their action plans below:

1) developerfred has been approved to start work.

I will remove support for old addresses and ensure that no transactions take place with the old format. Checked all source code carefully. 2) janus has applied to start work _(Funders only: approve worker | reject worker)_.

I recently worked for a client that encoded and decoded a large number of addresses from diverse blockchain networks. I have gained great skill in the area of address structure and format. I would apply this knowledge while carrying out your task. This task would be completed in days.

Learn more on the Gitcoin Issue Details page.

gitcoinbot commented 3 years ago

@developerfred Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

developerfred commented 3 years ago

Ok I will submit PR working progress today

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 1.0419 ETH (381.95 USD @ $367.25/ETH) has been submitted by:

Learn more on the Gitcoin Issue Details page
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Chat
$891,679.85 more funded OSS Work available on the Gitcoin Issue Explorer

ayushkumar63123 commented 2 years ago

I am working on this and will try to make a pr to resolve this issue

ayushkumar63123 commented 2 years ago

Shall I delete the whole code for p2p files not containing segwit and leave only p2p segwit files?