search

BitgesellOfficial / bitgesell

Bitgesell (BGL) is a digital currency with built-in scarcity
https://www.bitgesell.ca
MIT License
25 stars 37 forks source link

functional test p2p_dos_header_tree.py quarantine question #96

Closed gitcoindev closed 1 year ago

gitcoindev commented 2 years ago

hi @madnadyka I analyzed failure of functional test case test/functional/p2p_dos_header_tree.py and figured out it contains simulated fork with headers from bitcoin test network stored in test/functional/data/blockheader_testnet3.hex data file. In bitcoin the first checkpoint for test network happens fast in block 546 defined here https://github.com/bitcoin/bitcoin/blob/master/src/chainparams.cpp#L258 but for BGL the hardcoded check point for test network was removed https://github.com/BitgesellOfficial/bitgesell/blob/master/src/chainparams.cpp#L266 should we quarantine /disable the test case then?

gitcoindev commented 1 year ago

Fixed by https://github.com/BitgesellOfficial/bitgesell/pull/117

gitcoindev commented 1 year ago

Pull request merged, issue closed.