others will probably stay for now? the new api requires a parent window which we just don't have
[X] replace gdkkeysyms-compat with gdkkeysyms (7faa553e820b7b61abd7721e81eb0f22898f0b17)
[X] fix critical errors on start (required to make the release mode work)
[X] fix object import menu, it was broken before but it straight up crashes on gtk3 due to OOB access.
fix minor widget size/layout issues (if found)
[x] replace button-release-event with click
[x] remove gtk_window_set_keep_above as it causes a lot of issues
[x] add missing delete level button in right click menu
port the custom theme work to gtk3 css and re-enable it
[X] instead, enable prefer-dark-theme
re-enable custom layout for robot config menu item dropdowns (?)
WONTFIX as you're not supposed to do that on wrapper types...
that works on gtk2, but fails on gtk3 (not supposed to be used anymore)
nice-to-have:
Add a compile-time option/define that makes the game use GtkGlArea in a GtkWindow instead of sdl2, solves a lot of issues, including the popup menu ones. (maybe in a separate pr)
replaces gtk2 with gtk3, adds various minor ui improvements
status: ready to merge! π₯³
most (if not all) stuff works, all deprecated functions except
gtk_popup_menu
are removedTODOs
gtk-undo
withgtksourceview-4
gtk-undo
enable basic autocomplete (just suggest some keywords and globals, and existing tokens)it would've been cool to also add a simple syntax error checker (just compile on change and display the error)gtk_threads_start
andgdk_threads_enter
/gdk_threads_leave
gtk_settings_set_*_property
withg_*
functionsGtkMisc
Color
withRGBA
ColorsSelection
withColorChooser
GtkH*
GtkV*
GTK_STOCK_*
,gtk_image_from_stock
, ...gtk_flush()
withgdk_display_flush(...)
gtk_tree_view_set_rules_hint
gtk_scrolled_window_add_with_viewport
gdk_keyboard_grab
withgdk_seat_grab
gtk_dialog_get_action_area
, as access to action area is deprecated and discouraged (pack widgets into content area instead)GtkTable
withGtkGrid
(used all over the codebase π°)[Remove]
button next to individual entries insteadButton
in level properties withColorButton
ColorButton
spawning dialog behind. (215045015cf213e61f2951a27c638ff238f7e85f)gdkkeysyms-compat
withgdkkeysyms
(7faa553e820b7b61abd7721e81eb0f22898f0b17)button-release-event
withclick
gtk_window_set_keep_above
as it causes a lot of issuesport the custom theme work to gtk3 css and re-enable itre-enable custom layout for robot config menu item dropdowns (?)WONTFIX as you're not supposed to do that on wrapper types...that works on gtk2, but fails on gtk3 (not supposed to be used anymore)
nice-to-have:
define
that makes the game useGtkGlArea
in aGtkWindow
instead of sdl2, solves a lot of issues, including the popup menu ones. (maybe in a separate pr)next: