search

BitiTiger / qtcreator-plugin-discord-presence

Discord Rich Presence plugin for newer versions of Qt Creator (fork that follows Arch Linux's package versions)
GNU General Public License v3.0
0 stars 0 forks source link

The artifact's 7z file is embedded into a zip file #2

Open BitiTiger opened 8 months ago

BitiTiger commented 8 months ago

The downloaded CI artifact is a zip file which contains a 7z file. Qt Creator will fail to install the zip file because it is not expecting a nested archive. Someone could manually fix this after downloading it... or the CI could be changed. I think the solution is to not combine the plugin files into a single 7z archive, but to let GitHub handle the generation of the zip archive. This way the CI will still produce a single zip file artifact without any effort on the maintainer.

For reference, here is the current state of the files:

cait@Mikoshi ~/Hämtningar> unzip -l CuteDiscordPresence-12.0.2-linux-x64.zip 
Archive:  CuteDiscordPresence-12.0.2-linux-x64.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
    22370  2024-03-12 21:52   CuteDiscordPresence-12.0.2-linux-x64.7z
---------                     -------
    22370                     1 file
cait@Mikoshi ~/Hämtningar> 7z l CuteDiscordPresence-12.0.2-linux-x64.7z

7-Zip [64] 17.05 : Copyright (c) 1999-2021 Igor Pavlov : 2017-08-28
p7zip Version 17.05 (locale=sv_SE.UTF-8,Utf16=on,HugeFiles=on,64 bits,20 CPUs x64)

Scanning the drive for archives:
1 file, 22370 bytes (22 KiB)

Listing archive: CuteDiscordPresence-12.0.2-linux-x64.7z

--
Path = CuteDiscordPresence-12.0.2-linux-x64.7z
Type = 7z
Physical Size = 22370
Headers Size = 259
Method = LZMA2:96k
Solid = +
Blocks = 1

   Date      Time    Attr         Size   Compressed  Name
------------------- ----- ------------ ------------  ------------------------
2024-03-12 17:52:53 D....            0            0  lib
2024-03-12 17:52:53 D....            0            0  lib/qtcreator
2024-03-12 17:52:53 D....            0            0  lib/qtcreator/plugins
2024-03-12 17:52:53 ....A           24        22111  lib/qtcreator/libdiscord-rpc.so.12
2024-03-12 17:52:53 ....A        14064               lib/qtcreator/libdiscord-rpc.so.12.0.2
2024-03-12 17:52:53 ....A        72968               lib/qtcreator/plugins/libCuteDiscordPresence.so
------------------- ----- ------------ ------------  ------------------------
2024-03-12 17:52:53              87056        22111  3 files, 3 folders
cait@Mikoshi ~/Hämtningar>
eduardoc7 commented 6 months ago

Just commenting that this issue has been resolved in the latest changes to the plugin. You can check it out in the released version: https://github.com/eduardoc7/qtcreator-plugin-discord-presence/releases/tag/v0.1.0

And update your fork. Thank you for reporting