search

Bitmessage / PyBitmessage

Reference client for Bitmessage: a P2P encrypted decentralised communication protocol:
https://bitmessage.org/wiki/Main_Page
Other
2.83k stars 576 forks source link

Move loading cryptors into objectProcessor init. #2160

Closed PeterSurda closed 1 year ago

PeterSurda commented 1 year ago

Hello!

I found a floating bug on windows:

2022-12-19 01:52:30,013 - CRITICAL - Unhandled exception
Traceback (most recent call last):
 File "bitmessagemain.py", line 390, in <module>
 File "bitmessagemain.py", line 386, in main
 File "bitmessagemain.py", line 185, in start
 File "shared.py", line 157, in reloadBroadcastSendersForWhichImWatching
 File "helper_sql.py", line 46, in sqlQuery
AssertionError

I admit that moving shared.reloadBroadcastSendersForWhichImWatching() should be enough to solve it, but it seems logical to move all the cryptors as they mostly used (should be) by object processor. Also I like removing the import of shared.

So far I have no idea how to test this though.