Bitmessage / PyBitmessage

Reference client for Bitmessage: a P2P encrypted decentralised communication protocol:
https://bitmessage.org/wiki/Main_Page
Other
2.83k stars 576 forks source link

Use bytes() on keys to be hashable in Python3 #2243

Open kashikoibumi opened 6 months ago

kashikoibumi commented 6 months ago

This patch is a preparation to migration to Python3.

Use bytes() on keys to be hashable in Python3. Hash keys used in hashtables must be hashable. Although it is not problem in Python2, it is a problem in Python3. When slice or memoryview of mutable byte array is used as hash key in Python3, an exception is raised. To resolve the problem, this patch convert hash keys to immutable bytes by using bytes() function.