[Security] Update to PyQt5

ghost commented 7 years ago

As you know Qt4 is no longer receiving security updates, you should switch to Qt5 and its python bindings. The switch from pyqt4 to pyqt5 should be relatively easy according to pyqt documentation on this topic (for example here).

bmng-dev commented 7 years ago

It is not so much PyQt but Qt itself that is the issue. Windows XP is still a supported platform for PyBitmessage. However Windows XP (and Vista) is missing from Qt5's Supported Platforms, although Qt for Windows - Specific Issues indicate it might be possible to build Qt5 for Windows XP. I understand @PeterSurda builds Qt4 as part of the release process so it is up to whether he can successfully build Qt5 and ensure everything still works on Windows XP before switching.

ghost commented 7 years ago

Qt4 is not maintained by the Qt project, when bugs are discovered, users can and will be hacked through the old Qt. Additionally, Windows XP is no longer LTS of Windows. This is illogical.

ghost commented 7 years ago

Documentation / Upstream says it is possible to build Qt5 for XP.

Additional reading sources: https://doc.qt.io/qt-5/supported-platforms-and-configurations.html "using Qt 5.6, XP will be supported until March 16, 2019"

ghost commented 7 years ago

Ping on the ticket.

@PeterSurda @bmng-dev do you plan to fix this at all, and if you will fix it what's the targeted version for this? I also advise you to drop the idea of supporting an outdated, no longer supported, Microsoft system.

bmng-dev commented 7 years ago

Sorry @Ghost, it's not up to me. I don't know why @PeterSurda hasn't responded.

PeterSurda commented 7 years ago

There are no specific plans, there are higher priority things. I'd prefer code that works both with Qt4 and Qt5 if possible, if someone submits a pull request I'll be happy to look at it.

Lvl4Sword commented 7 years ago

@bmng-dev I'm confused as to why XP/Vista would be supported at all, since those are EOL according to Microsoft ( and thus should be updated/replaced ) I stand by ghost's advice on not standing by these out-of-date systems

bmng-dev commented 7 years ago

@Lvl4Sword you and me both. I'm just someone who is interested in Bitmessage like you. I am not, nor have I ever been, involved in the decision making process of this project. At the time I responded to @ghost I thought Windows XP was supported because of things I had read from @PeterSurda (other issues here on github, on the forums, reddit, or on the bitmessage chan I can't remember) and tried to be helpful with a timely response anticipating what some of @PeterSurda concerns might be about moving to Qt5. The jury is still out on whether I'm correct or not.

PeterSurda commented 7 years ago

Just to clarify:

at the moment, the backwards compatibility with Windows doesn't appear to create extra effort. I build the 32bit binaries on Windows 7, and while I do have a test environment for XP, I don't recall having problems since switching the build environment to Windows 7. Today's devel snapshot also works on Windows XP, even though I haven't done any tests on XP since releasing 0.6.2. I haven't really tested most of the post-0.6.2 changes on anything else than linux for that matter. It's possible that at some stage the backwards compatibility will break, and I'll make a decision at that time.
the reason why I haven't switched to PyQt5 is that it's lower priority than other things. I don't know what the differences between Qt4 and Qt5 are and I'm not a UI specialist.

a17r commented 6 years ago

Please note that Qt4 and PyQt4 support is being dropped in distributions everywhere at this point, since being unmaintained for years.

PeterSurda commented 6 years ago

Sadly, I'm busy with more urgent issues and I've never used PyQt5 before. Maybe someone else can do that. @g1itch any interest?

g1itch commented 6 years ago

Actually I started already. And have first preview.

PeterSurda commented 6 years ago

Excellent, thank you very much!

g1itch commented 6 years ago

The branch

PeterSurda commented 6 years ago

@g1itch I sent you an email, did you get it?

g1itch commented 6 years ago

Yes, I'll try to grab some words and give a proper answer.

g1itch commented 6 years ago

Huh, it's almost done. I guess it will require a massive beta-test (or alpha?). I've used QtPy, so it will be compatible with PyQt4 and pyside.

NourEddineX commented 5 years ago

Hello , please note that PyQt4 has been dropped from Manjaro, one of major desktop linux distros

Jacalz commented 5 years ago

Solus are planning to deprecate Qt4, getting it ported to Qt5 would make it possible to still be included in the repo...

g1itch commented 5 years ago

Solus are planning to deprecate Qt4, getting it ported to Qt5 would make it possible to still be included in the repo...

It's already ported, just still is not included into v0.6. You can take my qt5-wip branch for you repo.

Jacalz commented 5 years ago

Wonderful, that is great news :+1:

baerbock commented 5 years ago

Hello , please note that PyQt4 has been dropped from Manjaro, one of major desktop linux distros

LOL. Manjaro is ArchLinux with parental advisory!

Bitmessage / PyBitmessage

[Security] Update to PyQt5 #897