search

BitnineGlobal / agensgraph

Apache License 2.0
24 stars 5 forks source link

AgensGraph 2.14 has issue with agensgraph-node driver #20

Open shinhanbyeol opened 2 months ago

shinhanbyeol commented 2 months ago

@eyab

image I felt something question in "AgensGraph".

Earlier versions returned numeric strings with clear id values, but now they return text containing properties as id values.

Although the id function is doing its job safely,

"agensgraph-node-diverver" and others refuse to process Korean characters in parsing expression grammar (peg).

It can be solved by modifying the "agensgraph-node-dirver" peg processing logic to support korean as well

but

Since the id value was never returned like the image attached in the existing "AgensGraph", I think it is necessary to modify the way the "AgensGraph" handles the id value

shinhanbyeol commented 2 months ago

sorry....

When I checked more, it seems that it is not only a problem of 2.14 but also a problem that has occurred in the past.

There was the same issue in version 2.5.0. It appears that I misunderstood something,

It may need to be corrected so that there is no problem when looking up the Korean label node in the agensgraph-node driver.

shinhanbyeol commented 2 months ago

As mentioned above, I thought it was the right issue to fix the agensgrahp-nodejs driver. First of all, in Korea, the response to Korean labels was considered an important issue, so we made a pull request after modifying it so that the driver could respond to Korean.

https://github.com/BitnineGlobal/agensgraph-nodejs/pull/1