search

Bitshala-Incubator / silent-pay

a TS library for silent payments
MIT License
8 stars 10 forks source link

Track spending transactions in database #24

Open theanmolsharma opened 5 months ago

theanmolsharma commented 5 months ago

In the current implementation, we don't save the transactions where we spend from our wallet. We should probably start doing that by making a function that allows users to list/track such transactions.

Implementation details are still not clear in my head right now but we can use this issue to discuss them.

emjshrx commented 5 months ago

saveSpendTransaction(txId:string,label:string) getSpendTransactions():Record<string,string>[]

We can get transaction details if needed from txId from the network?

Ayush170-Future commented 4 months ago

Hey @emjshrx,

Could you provide me with some ideas on how to begin with this issue? Should these functions be created in the WalletDB (Level DB)? I'm a little confused about the part regarding saving the transactions where we spend from our wallet. Aren't all transactions spent from our wallet? Or is this something specific to BIP 352, meaning I have to read it completely?

Just tell me something, so that I can start in the right direction.

emjshrx commented 4 months ago

This issue hasnt been discussed to its fullest and actually might not be needed for our PoC. Lets discuss in this weeks call. cc @theanmolsharma

aruokhai commented 1 month ago

Any update regarding this ?