search

Bitshala-Incubator / silent-pay

a TS library for silent payments
MIT License
11 stars 12 forks source link

feat: add lookahead #33

Closed emjshrx closed 7 months ago

emjshrx commented 7 months ago

fixes #20 . Didnt feel any new tests are needed, lmk if otherwise

emjshrx commented 7 months ago

PR looks solid apart from one minor change. Nice work!!

About the tests, I think this change should be accompanied by some tests. You can directly check in the db whether 10 addresses are being generated on init() and then for subsequent addresses make sure i + 10th address is being saved in db.

Addressed comments