test: add coverage for dust mempool policy (-dustrelayfee setting) #26631 - Githubissues

Bitshala / BitcoinCore-PR-Review-Club

Bitcoin Core PR Review Organising repo

10 stars 2 forks source link

test: add coverage for dust mempool policy (-dustrelayfee setting) #26631 #1

Closed rajarshimaitra closed 1 year ago

rajarshimaitra commented 1 year ago

Session Details

Date: 12-01-2023
Time: IST 20:00 (UTC 14:30)
Jitsi: https://meet.jit.si/BitshalaPRReviewClub
PR: https://github.com/bitcoin/bitcoin/pull/26631
Context: Functional Test
Difficulty: Easy
Language: ['python']
Notes and Questions: https://bitcoincore.reviews/26631 [also checkout previous chat recordings]

Summary

This PR adds a new functional test to cover previously uncovered mempool dustRelayFee policy, including the default feerate setting for dust policy.

Learning

Introduction to functional test framework of Bitcoin Core.
Useful functions and patterns to write functional tests.
Understanding testing approaches and their limitations.
Observing the internal regtest node state by add calls to self.nodes[0].<rpc-call> and other objects. Use python debugging tools pause execution at specific steps.
Trying to figure out improvements.

Note: Drop your PR and review related questions below