search

Bitshala / BitcoinCore-PR-Review-Club

Bitcoin Core PR Review Organising repo
10 stars 2 forks source link

TWR_EP02_PR #28528_2024-01-04 final #52

Closed rajarshimaitra closed 5 months ago

rajarshimaitra commented 5 months ago

https://drive.google.com/file/d/1G-UB49iuKuddvobm1kbBK8hhOV6He875/view?usp=drive_link

Timelines here : PR #28528 7:00 - Assert equal for debugging 18:16 - what is the effective way of reviewing this kind of PR 50:53 - Qna

less timelines as most of the video part was just trying to figure out some stuffs....

rajarshimaitra commented 5 months ago

@stratospher, we need a YouTube description for this episode. Check our previous descriptions for the template. Okay, if a timeline is not provided.

@paperpsych we need youtube thumbnail for this one.

Tags:

Functional Tests

PR Review Basics

Util

stratospher commented 5 months ago

Description

Part 2 of our "Together We Review Series"! Reviewing PRs is the best way to contribute to Bitcoin Core. We pick a few easy PRs and go through them together on the call.

In this club during the club, we reviewed "test: Use test framework utils in functional tests #28528"

For more details on this Review Club Series, check the series issue: https://github.com/Bitshala/BitcoinCore-PR-Review-Club/discussions/50 Review Club Joining instruction: https://github.com/Bitshala/BitcoinCore-PR-Review-Club Website: https://bitshala.org/review/

bitshala #bitcoin #technology

Subscribe to our channel! @bitshala

paperpsych commented 5 months ago

Here is the thumbnail!

VirdiJatin commented 5 months ago

@rajarshimaitra @stratospher ping for tweet.. here's the youtube link https://youtu.be/Rn2NS4w-Iy4?si=HW1DrPkyi4dx9PrQ

rajarshimaitra commented 5 months ago

Tweet: https://x.com/bitshala_org/status/1751611136846569558?s=20