This PR introduces tracking of per-peer reconciliation sets containing transactions to be exchanged efficiently using minisketch.
Currently all the transaction are flooded to each peer via flooding algorithm .
The section to be reviewed is txreconciliation.h/txreconciliation.cpp and txreconciliation_tests.cpp.
Questions
Why testing with Boost library and not use python tests ?
Functional tests vs Unit Tests .
MAX_SET_SIZE for wtixd is capped at 3000 . Why is that ?
Session Details
Date : 13-06-2024 Time: IST 20:00 (UTC 14:30) Link : p2p: Fill reconciliation sets (Erlay) BIP : 330 Difficulty : High
Notes
This PR introduces tracking of per-peer reconciliation sets containing transactions to be exchanged efficiently using minisketch. Currently all the transaction are flooded to each peer via flooding algorithm .
The section to be reviewed is
txreconciliation.h/txreconciliation.cppandtxreconciliation_tests.cpp.Questions
Learnings
sketches erlay multi-threaded architecture
Pre-Requisites
PR review club - BIP330 guide to run tests in bitcoin-core