search

Bitshala / BitcoinCore-PR-Review-Club

Bitcoin Core PR Review Organising repo
10 stars 2 forks source link

rpc: Add test-only RPCs under `-test=<option>` flag #78

Closed Prabhat1308 closed 3 days ago

Prabhat1308 commented 2 weeks ago

Session Details

Date:05-09-2024 Time: IST 20:00 (UTC 14:30) Link : https://github.com/bitcoin/bitcoin/pull/30717 Difficulty : Medium

Notes

This PR splits off test-only RPCs to be included in -test flag with additional restrictions of use in regtest segregating the user facing and testing RPCs . These test-only RPCs are split off from args and have their own method to extract arguments .

Questions

  1. What is the need to differentiate normal RPCs and test RPCs ?
  2. How do we identify dev-only RPC ?
  3. What is the need to limit the -test RPC to regtest and not other testnets ?

Learning

RPC tests

paperpsych commented 2 weeks ago

@VirdiJatin ... And @Prabhat1308 please confirm if the tags are good to go!

Bitshala RC (30717)

Prabhat1308 commented 2 weeks ago

@paperpsych these are good to go.