BittyTax / BittyTax

Crypto-currency tax calculator with support for all popular wallets, exchanges, explorers and migration from other crypto tax platforms
GNU Affero General Public License v3.0
416 stars 110 forks source link

Crypto.com change of Transaction Kind #356

Closed Roadrunneruk closed 5 months ago

Roadrunneruk commented 5 months ago

Back in January 2024 Crypto.com changed the way they did locking up cro coins for they debit card, is was

Transaction Description CRO Lockup Rewards

Transaction Kind mco_stake_reward

and has now changed to

Transaction Description Cardholder CRO Stake Reward

Transaction Kind finance.lockup.dpos_compound_interest.crypto_wallet

These changes need to be made to the parser.

Crypto.com unlocked your cro coins and they re-staked using this transaction kind which needs to be add to the parser

finance.lockup.dpos_lock.crypto_wallet

One thing that stands out is the word interest in "finance.lockup.dpos_compound_interest.crypto_wallet" does this come under miscellaneous income for tax purposes or is it under your £1000 allowance for interest from savings Ive included a section on the new staking of cro coins, my reading of this is that it's still coming under miscellaneous income for tax

What is CRO Lockup, and how is it different from Cardholder CRO Staking?

CRO Lockup grants you various benefits for your Crypto.com Visa Card, Crypto Wallet, and Crypto Earn. Refer to the ‘CRO Lockup Benefits’ section below for more details. Cardholder CRO Staking replaces CRO Lockup from 15 January 2024, 03:00 UTC, for eligible users. Under Cardholder CRO Staking, your CRO is staked on-chain, and you participate in securing the underlying blockchain (learn more in this University article). The reward rates for staking are dependent on the blockchain and may be subject to change. Rewards are paid weekly to your CRO Cardholder Stake, thus compounding your returns. The staking and unstaking processes require an activation and unbonding period, respectively. CRO Lockup allows you to enjoy the same Crypto.com Visa Card, Crypto Wallet, and Crypto Earn benefits as Cardholder CRO Staking. However, as your CRO is not staked on-chain, reward rates are set by Crypto.com based on market conditions. Additionally, rewards are not compounded.

crypto_transactions_record.csv

nanonano commented 5 months ago

Hi Andy, thanks for raising this, I've done a patch, see https://github.com/BittyTax/BittyTax/commit/5fa25a69d5f21340f4caf25a4064cecabcf4e8ef. Please re-test.

Roadrunneruk commented 5 months ago

Sorry Scott, when I run it comes up with the following errors

Traceback (most recent call last): File "/home/grandmaster/.local/bin/bittytax_conv", line 8, in sys.exit(main()) File "/home/grandmaster/.local/lib/python3.10/site-packages/bittytax/conv/bittytax_conv.py", line 133, in main _do_read_file(file_type, pathname, args) File "/home/grandmaster/.local/lib/python3.10/site-packages/bittytax/conv/bittytax_conv.py", line 185, in _do_read_file DataFile.read_csv(pathname, args) File "/home/grandmaster/.local/lib/python3.10/site-packages/bittytax/conv/datafile.py", line 254, in read_csv data_file.parse( File "/home/grandmaster/.local/lib/python3.10/site-packages/bittytax/conv/datafile.py", line 79, in parse data_row.parse(self.parser, kwargs) File "/home/grandmaster/.local/lib/python3.10/site-packages/bittytax/conv/datarow.py", line 36, in parse parser.row_handler(self, parser, kwargs) File "/home/grandmaster/.local/lib/python3.10/site-packages/bittytax/conv/parsers/cryptocom.py", line 133, in parse_crypto_com TrType.CASHBACK, File "/usr/lib/python3.10/enum.py", line 437, in getattr raise AttributeError(name) from None AttributeError: CASHBACK

On Fri, 5 Apr 2024 at 16:49, Scott Green @.***> wrote:

Hi Andy, thanks for raising this, I've done a patch, see 5fa25a6 https://github.com/BittyTax/BittyTax/commit/5fa25a69d5f21340f4caf25a4064cecabcf4e8ef. Please re-test.

— Reply to this email directly, view it on GitHub https://github.com/BittyTax/BittyTax/issues/356#issuecomment-2040140466, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACIWQETFSLH6O2QS33FPLDTY33BZFAVCNFSM6AAAAABFUZGH7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGE2DANBWGY . You are receiving this because you authored the thread.Message ID: @.***>

nanonano commented 5 months ago

Hi Andy, it looks like you're are missing a previous commit, this one: https://github.com/BittyTax/BittyTax/commit/82394a8336713bc42ffc6a5e7d579970f3fae24e. Please download and re-install from GitHub.