BitzenyCoreDevelopers / bitzeny

[z2.0.x] BitZeny Core integration/staging tree created by the New Dev team
https://bitzeny.info
MIT License
94 stars 32 forks source link

Fix bitcoin-tx utilities test. #21

Closed onokatio closed 6 years ago

onokatio commented 6 years ago

Fix about test/util/bitcoin-util-test.py

onokatio commented 6 years ago

Note: Address generate

(to fix src/test/base58_tests.cpp)

onokatio commented 6 years ago

Note: Transaction Version

2018-01-19 21:38:29,421 - ERROR - Output data mismatch for blanktxv2.json (format json)
2018-01-19 21:38:29,422 - ERROR - Output formatting mismatch for blanktxv2.json:
*** blanktxv2.json
--- returned
***************
*** 1,7 ****
  {
!     "txid": "4ebd325a4b394cff8c57e8317ccf5a8d0e2bdf1b8526f8aad6c8e43d8240621a",
!     "hash": "4ebd325a4b394cff8c57e8317ccf5a8d0e2bdf1b8526f8aad6c8e43d8240621a",
!     "version": 2,
      "size": 10,
      "vsize": 10,
      "locktime": 0,
--- 1,7 ----
  {
!     "txid": "d21633ba23f70118185227be58a63527675641ad37967e2aa461559f577aec43",
!     "hash": "d21633ba23f70118185227be58a63527675641ad37967e2aa461559f577aec43",
!     "version": 1,
      "size": 10,
      "vsize": 10,
      "locktime": 0,

An error has occurred because of diffirent transaction version. The version is define ad BIP68. This BIP allows blockchain to use HTLC(Hashed Timelock Contracts). It is soft fork.

I think it is need for bitzeny, but it is softfork. So i posted about it to forum. (https://bitzeny.info/d/39-z2-0-x/297) Please read. I want your opinion.

onokatio commented 6 years ago

@rmdfwqclmrkcvpbe @hitobb Please review.

onokatio commented 6 years ago

I add some test.

onokatio commented 6 years ago

@rmdfwqclmrkcvpbe @hitobb Please review.