Fonts on the site - Githubissues

Bixal / bixal-site-drupal

Bixal drupal site

https://www.bixal.com

0 stars 0 forks source link

Fonts on the site #125

Closed mpbixal closed 2 months ago

mpbixal commented 6 months ago

Are we using Bixal brand fonts, or alternate fonts? I assume alternate.

Instances of Georgia need to have tighter leading than Helvetica Neue

@mejiaj are the fonts on the site consistent? Are they loading properly on the Drupal implementation?

mejiaj commented 2 months ago

@mpbixal font from typekit (Novel Pro [header] & Proxima Nova [body]) seems to be loading.

I do see a 404 on the USWDS font source sans pro, but we're not using it. Looks like that's being set in a USWDS style for the .usa-prose class. We should fix that.

mattsqd commented 2 months ago

@mejiaj here's what we did https://github.com/Bixal/bixal-site-drupal/pull/211

Added the font files that were 404'n
Removed the usa-prose class from the body since it's not in story book.

mejiaj commented 2 months ago

We shouldn't be using usa-prose since it includes a lot of overrides. If we want to improve readability we should create our own class for it.

I still see it on the homepage:

mattsqd commented 2 months ago

Thanks @mejiaj ! That makes sense. This change has not been deployed to prod yet.