Open buddy-harlow opened 2 months ago
@mpbixal Do you think the closing of #268 will also fix this issue?
@mpbixal Do you think the closing of #268 will also fix this issue?
I don't think so, #268 just included the CSS, it did not change the dom. For example here is the USWDS paging component:
and here is ours:
Our classes our the same, the difference is that USWDS uses aria-label
and we use title
. And the values for those are different.
So I assume, we need to use aria-label
and switch to just Page 1
. Also, check the other title
values, like 'current page' and 'next page'.
I'm not sure if the link
in:
I expect the pagination page links to announce as "Page 1 link" "Page 2 link"
is actually in the aria-label
as well, or if screen readers just announce the HREF value after they read the aria-label
.
Location: https://www.bixal.com/blog
Suggestion
I recommend we adopt USWDS Pagination component's visual styling and code as it is more intuitive.