Closed mejiaj closed 6 months ago
@mejiaj Thanks James, this looks great. I updated the section component references to match up with the changes I made to upstream. I had change block body to variable body (That's easier for Drupal to work with and there is no default content or wrapper on body).
I think we might have discussed this slightly, but how did you envision the editorial process for a single contract vehicle would look?
Single contract vehicle A) Multiple explicit text boxes all on the page ('Marketing materials', 'Contractor Capabilities', etc) and they enter a value if they want The items are always in the same order, they are locked into the only these items unless we make a code change B) Single field with 'add another' button, Each item is a drop down of the items ('Marketing materials', 'Contractor Capabilities', etc) and a text box The items could be in any order, they could add more items into the drop down via a vocabulary C) Single text area field, they just enter each header + text as they see fit Total editorial independence D) These could simply be 'Section' paragraphs that we already have Section paragraphs add an extra section 'section content' every time a new one is added, it's also harder to add a 'body' with HTML as you need. We actually don't even have a WYSIWYG field anywhere yet.
I saw that 'heading type' is a variable in the page, did you want to allow them to change this at will? (C) supports that out of the box, A & B would require another drop down (easy). We probably need to add heading top as a drop down for our section paragraph, we don't have it.
Contract landing page Similar to the last one, except it does not allow a heading change, it's always H2
@mpbixal thanks for taking a look.
I think we might have discussed this slightly, but how did you envision the editorial process for a single contract vehicle would look?
Option A , is nice because it enforces consistency. Any sections that don't apply can be left out. Option B is a close second option. It allows a little more control, but seems unnecessary at this point in time.
Options C & D are nice for freedom, but it'd cause a lot of inconsistencies.
I saw that 'heading type' is a variable in the page, did you want to allow them to change this at will? (C) supports that out of the box, A & B would require another drop down (easy). We probably need to add heading top as a drop down for our section paragraph, we don't have it.
Your comment made me realize there were two issues with this.
h1
. Now the General Overview
section is the h1 to address that a11y issue.heading_type
wasn't being set correctly. But this setting came from section and it allows us to adjust headers to follow the page order (another a11y). For contract vehicles we only need it to differentiate the first section.I've fixed these issues in 9098578.
The h2
's are fine because this page has a hero and the page heading order is good. I left a hero out of the single pages because it looked out of place.
@buddy-harlow Capturing here the follow-up from teams for the implementation in Drupal
Contract vehicle landing & individual page. Closes #51.