Urgent bug: game gets in bad state. UFOs being detached from their controller.

[JSideris]

Getting a bug where UFOs vanish from client, and eventually server errors about UFOs being detached form a controller. More investigation in comments.

[JSideris]

Ships randomly disappear, while their red circle remains for a while longer. Very hard to catch in action.

[JSideris]

Possibly related:

[JSideris]

Charlie III is in this state here.

Still appears in this.objects on the game instance.

One of the updates han NaN in it:

This is the code for target angle. May be related to setting the mouse coords?

Edit: the NaN angle was an unrelated bug. But may have caused the ship to disappear. There still seems to be other issues. See below.

[JSideris]

Some updates for objects that don't even have IDs?

Also, it seems upgrade modules are now not being loaded.

Also noticed a lot of map marker issues, and sometimes no marker appearing in game - reverse tag should ALWAYS have a marker on screen.

Theory: overlapping IDs for map markers and they objects they're tracking?

[JSideris]

Possibly also related to state machine errors:

[JSideris]

Summary:

• [x] Anchor issue probably always existed. It's not a serious problem, but is a potential red flag. Could indicate that ai controllers persist in some from after their robots have been destroyed, maybe through visible to users. Possibly solved in #1130?
• [x] Target angle bug was resolved as an unrelated thing, caused by recent refactoring and AI enhancements. Resolved.
• [x] Upgrade to undefined was because I was referring to u.comp.id when this particular update uses u.comp.entityId. The AI not being loaded was a serious problem, but may have happened due to the undefined angle problem above, or something similar. Will keep an eye on it.
• [ ] Updates to the upgrade module are still illusive. But it's not a very serious problem.
• [ ] The skipping the death menu respawn button is a more concerning issue. But it is likely unrelated.