Bjorn-Strom / FSS

MIT License
101 stars 4 forks source link

[Question/Proposal] Would need to mention @emotion/css in docs? #33

Open darren-mk opened 1 year ago

darren-mk commented 1 year ago

Thanks for the great work, first of all. After installed Fss using paket, my SAFE project prompts to install @emotion/css as well. If this an intended behavior, maybe does its docs need to mention? Or does the source code need to be updated somehow.

Bjorn-Strom commented 1 year ago

Hello and thank you so much.

The previous version of FSS used emotion, the new one does not. When releasing the new one I decided to make a totally new Nuget package, make sure you are using Fss-lib-{library specific package}. If you are using SAFE then fss-lib.fable might be what you are after.

Let me know if that helps!

darren-mk commented 1 year ago

Sure. This is what I installed through paket.

  Fss-lib (2.0.5)
      Fable.Core (>= 3.2.6)
      Fable.Elmish.React (>= 3.0.1)
      Fable.React (>= 7.3)
      FSharp.Core (>= 5.0.1)
    Fss-lib-feliz (1.0)
      Fable.Core (>= 3.2.8)
      Feliz (>= 1.47)
      FSharp.Core (>= 5.0.1)
      Fss-lib (>= 2.0.2)

Maybe this isn't the most recent version - I will check again.

And the SAFE template uses Feliz by default, but should I still use fss-lib.fable?

Bjorn-Strom commented 1 year ago

I see. Yes that is the old version, you would want this one: https://www.nuget.org/packages/Fss-lib.Feliz/

I havent used SAFE in ages so I did not know it used Feliz now.

I will go make sure the old ones are marked as deprecated on nuget. If you get the above package, does it work then?

darren-mk commented 1 year ago

Sure. I believe your new version is fine but it seems the SAFE project is somewhat behind. I got these errors when I tried the newest version, 2.2.0.

% paket add Fss-lib.Feliz --version 2.2.0
Paket version 7.1.5+e2fe7c693356a5e70a74cc01501f7dc5f8996695
Adding package 'Fss-lib.Feliz' 2.2.0
Resolving dependency graph...
  Conflict detected:
   - Fss-lib.Fable 2.2.0 requested package Fable.Browser.Dom: >= 2.10
   - Fable.React 7.4.3 requested package Fable.Browser.Dom: >= 2.4.4

The process is taking longer than expected.
Paket may still find a valid resolution, but this might take a while.
  Conflict detected:
   - Fss-lib.Fable 2.2.0 requested package Fable.Browser.Dom: >= 2.10
   - Fable.React 7.4.3 requested package Fable.Browser.Dom: >= 2.4.4

The process is taking longer than expected.
Paket may still find a valid resolution, but this might take a while.
  Conflict detected:
   - Fss-lib.Fable 2.2.0 requested package Fable.Browser.Dom: >= 2.10
   - Fable.React 7.4.3 requested package Fable.Browser.Dom: >= 2.4.4

The process is taking longer than expected.
Paket may still find a valid resolution, but this might take a while.
  Conflict detected:
   - Dependencies file requested package Fable.Core: >= 0
   - Fss-lib.Fable 2.2.0 requested package Fable.Core: >= 3.7.1
   - Fable.Elmish.Debugger 3.3 requested package Fable.Core: >= 3.2.8
... (and more)
darren-mk commented 1 year ago

Maybe I should pick the newest version possible that is compatible with the SAFE project (it is the current version but it uses some old dependencies).

-- In fact, I found that all versions in this package aren't compatible with SAFE, starting with version 1.0.0.

% paket add Fss-lib.Feliz --version 1.0.0
Paket version 7.1.5+e2fe7c693356a5e70a74cc01501f7dc5f8996695
Adding package 'Fss-lib.Feliz' 1.0.0
Resolving dependency graph...
     Fable.Browser.XMLHttpRequest 1.1.5 was unlisted
     Fable.Browser.XMLHttpRequest 1.1.4 was unlisted
     Fable.Browser.XMLHttpRequest 1.1.3 was unlisted
  Conflict detected:
   - Fss-lib.Fable 1.0.0 requested package Fable.Browser.Dom: >= 2.9
   - Fable.React 7.4.3 requested package Fable.Browser.Dom: >= 2.4.4

The process is taking longer than expected.
Paket may still find a valid resolution, but this might take a while.
  Conflict detected:
   - Fss-lib.Fable 1.0.0 requested package Fable.Browser.Dom: >= 2.9
   - Fable.React 7.4.3 requested package Fable.Browser.Dom: >= 2.4.4

The process is taking longer than expected.
Paket may still find a valid resolution, but this might take a while.
  Conflict detected:
   - Fss-lib.Fable 1.0.0 requested package Fable.Browser.Dom: >= 2.9
   - Fable.React 7.4.3 requested package Fable.Browser.Dom: >= 2.4.4

The process is taking longer than expected.
Paket may still find a valid resolution, but this might take a while.
  Conflict detected:
   - Fss-lib.Fable 1.0.0 requested package Fable.Browser.Dom: >= 2.9
   - Fable.React 7.4.3 requested package Fable.Browser.Dom: >= 2.4.4

The process is taking longer than expected.
Paket may still find a valid resolution, but this might take a while.
Updated packages:
  Group: Main

I think I should stick to the earlier package (I don't mind installing emotion).

Bjorn-Strom commented 1 year ago

I see. I do not use SAFE so I am not sure what limitations it has. Is it a possibility to update its dependencies manually?

You can for sure use the first version. But keep in mind that the API has changed and the current documentation reflects that. You can of course check out the history of the markdown files themselves in the repository.