BjornFJohansson / pydna

Clone with Python! Data structures for double stranded DNA & simulation of homologous recombination, Gibson assembly, cut & paste cloning.
Other
166 stars 45 forks source link

Infinite loop #133

Closed jefe-jeff closed 1 year ago

jefe-jeff commented 1 year ago

Currently, if you run primer_design on a fragment that's too short, it sets off an infinite loop. Perhaps it could throw an error instead? Following example should reproduce the problem.

from pydna.design import primer_design from pydna.all import * fragment = Dseqrecord("GCCACCATGG") primer_design(fragment)

BjornFJohansson commented 1 year ago

Thank you for taking the time to report this. Indeed an undesirable behaviour.

manulera commented 1 year ago

This does not seem to happen anymore @BjornFJohansson. Should we close?

BjornFJohansson commented 1 year ago

yes!