BjornFJohansson / pydna

Clone with Python! Data structures for double stranded DNA & simulation of homologous recombination, Gibson assembly, cut & paste cloning.
Other
160 stars 39 forks source link

Unexpected products from assemblies? #166

Open manulera opened 7 months ago

manulera commented 7 months ago

Here I have included two python scripts that produce what i think are unexpected results of the Assembly (see the comments). You can execute them without installing anything in the repo, just copy the files in pydna_examples and run them in a virtual env where pydna is installed.

BjornFJohansson commented 7 months ago

Hi sorry for the delay. My email notification was off for github for some reason.

BjornFJohansson commented 7 months ago

See my fork: https://github.com/BjornFJohansson/ShareYourCloning_backend/tree/dummycheck/pydna_examples

I branched off master to branch "dummycheck" and made some cosmetic changes to dummy2.py Made some comments on the linear example (so far) to "comments_dummy2.md"

BjornFJohansson commented 7 months ago

Now complete, I think the dummy3 example reflects a problem in the algorithm.

Nice video about the process we try to model: Single-Strand Annealing - Jim Haber (Brandeis) https://youtu.be/B7Vp5pYOIGc

manulera commented 7 months ago

Hi @BjornFJohansson thanks for having a look. I read through your response and if I understand correctly:

The way I am doing it now with the alternative assembly implementation is by restricting to each fragment only once. This does not represent the full experimental possibilities, but I think that constrain satisfies better my use-case. I think what could be done is return a warning if infinite assemblies or assemblies with repeated fragments can be formed? This probably can be obtained from the graph topology.