search

BjornFJohansson / pydna

Clone with Python! Data structures for double stranded DNA & simulation of homologous recombination, Gibson assembly, cut & paste cloning.
Other
166 stars 45 forks source link

New assembly: option to add feature with assembly scars #193

Open manulera opened 9 months ago

manulera commented 9 months ago

In the new assembly implementation, it would be good to have a boolean option to select whether features are added to indicate where joins between fragments happened.

BjornFJohansson commented 8 months ago

Yes! I have though of a different solution to this, but never got around to it. The features is a list property of the seq object. Perhaps, the scar features could be saved in another list that could be appended or not to the feature list. That way they are there, but only visible if the user wants them.

manulera commented 8 months ago

I personally think deciding in advance (default=False) whether to include them or not in the normal seqfeature list would be simpler downstream than adding a separate property to the Dseqrecord class.

A separate property would require handling when exporting to gb files and when doing further manipulations to the sequence (e.g. a cut).

What do you think?

BjornFJohansson commented 8 months ago

Sounds good as well. Go for it!