Open dgruano opened 3 months ago
Hi and thanks for your interest in pydna. I have been busy with this years round of grant proposals, nomrally I try to respond quicker.
The crispr module right now is a minimally working example. I think the way to go here is to specify something that intuitively describes a linear ssDNA molecule. In pydna, Dseq and Dseqrecords are used for dsDNA. I think better type hinting at the least and perhaps accepting pydna.seqrecord.SeqRecord would make sense?
I was playing around with the
crispr
module and came across a weird error where the cut coordinates of acas9
object were way larger than the target sequence.The problem was that I was passing a
Dseqrecord
object and not astring
. I am not very familiar yet with the rest ofpydna
so do most functions require astring
or aDseq
/Dseqrecord
object? Should we check the input type within the functions or add type hinting?Let me know if I can help.