BjornFJohansson / pydna

Clone with Python! Data structures for double stranded DNA & simulation of homologous recombination, Gibson assembly, cut & paste cloning.
Other
161 stars 41 forks source link

Issue 238 #239

Closed manulera closed 1 month ago

manulera commented 1 month ago

Closes #238

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.66%. Comparing base (009ad15) to head (ce62d6a).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/BjornFJohansson/pydna/pull/239/graphs/tree.svg?width=650&height=150&src=pr&token=8gKFpo7HAl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bj%C3%B6rn+Johansson)](https://app.codecov.io/gh/BjornFJohansson/pydna/pull/239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bj%C3%B6rn+Johansson) ```diff @@ Coverage Diff @@ ## dev_bjorn #239 +/- ## ============================================= - Coverage 93.66% 93.66% -0.01% ============================================= Files 40 40 Lines 3868 3867 -1 Branches 577 576 -1 ============================================= - Hits 3623 3622 -1 Misses 196 196 Partials 49 49 ``` | [Files](https://app.codecov.io/gh/BjornFJohansson/pydna/pull/239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bj%C3%B6rn+Johansson) | Coverage Δ | | |---|---|---| | [src/pydna/dseqrecord.py](https://app.codecov.io/gh/BjornFJohansson/pydna/pull/239?src=pr&el=tree&filepath=src%2Fpydna%2Fdseqrecord.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bj%C3%B6rn+Johansson#diff-c3JjL3B5ZG5hL2RzZXFyZWNvcmQucHk=) | `93.70% <100.00%> (-0.02%)` | :arrow_down: |
manulera commented 1 month ago

I think this can be merged, the hit in lines covered is because there are fewer lines now, but the patch is 100% covered by tests.

manulera commented 1 month ago

@BjornFJohansson I will merge this since I don't think it breaks anything!