BjornFJohansson / pydna

Clone with Python! Data structures for double stranded DNA & simulation of homologous recombination, Gibson assembly, cut & paste cloning.
Other
166 stars 45 forks source link

Issue 237 optimisation #250

Closed manulera closed 3 months ago

manulera commented 3 months ago
primer_design(dseqr, target_tm=55, tm_func=tm_neb, estimate_function=tm_default)
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.92%. Comparing base (7747787) to head (7e4f306). Report is 2 commits behind head on dev_bjorn.

Files Patch % Lines
src/pydna/tm.py 87.50% 1 Missing and 1 partial :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/BjornFJohansson/pydna/pull/250/graphs/tree.svg?width=650&height=150&src=pr&token=8gKFpo7HAl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bj%C3%B6rn+Johansson)](https://app.codecov.io/gh/BjornFJohansson/pydna/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bj%C3%B6rn+Johansson) ```diff @@ Coverage Diff @@ ## dev_bjorn #250 +/- ## ============================================= + Coverage 93.66% 93.92% +0.25% ============================================= Files 40 40 Lines 3867 4080 +213 Branches 576 666 +90 ============================================= + Hits 3622 3832 +210 - Misses 196 200 +4 + Partials 49 48 -1 ``` | [Files](https://app.codecov.io/gh/BjornFJohansson/pydna/pull/250?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bj%C3%B6rn+Johansson) | Coverage Δ | | |---|---|---| | [src/pydna/design.py](https://app.codecov.io/gh/BjornFJohansson/pydna/pull/250?src=pr&el=tree&filepath=src%2Fpydna%2Fdesign.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bj%C3%B6rn+Johansson#diff-c3JjL3B5ZG5hL2Rlc2lnbi5weQ==) | `97.51% <100.00%> (+0.31%)` | :arrow_up: | | [src/pydna/tm.py](https://app.codecov.io/gh/BjornFJohansson/pydna/pull/250?src=pr&el=tree&filepath=src%2Fpydna%2Ftm.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bj%C3%B6rn+Johansson#diff-c3JjL3B5ZG5hL3RtLnB5) | `96.92% <87.50%> (-3.08%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/BjornFJohansson/pydna/pull/250/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bj%C3%B6rn+Johansson)
manulera commented 3 months ago

Tests are missing here, I will add them. Don't merge yet!

manulera commented 3 months ago

@hiyama341 this is ready and tested, have a look at the description to see how to use it!

manulera commented 3 months ago

@BjornFJohansson please have a look, I think this can be safely merged