search

BjornFJohansson / pydna

Clone with Python! Data structures for double stranded DNA & simulation of homologous recombination, Gibson assembly, cut & paste cloning.
Other
166 stars 45 forks source link

fix icon link + 2 small bug fixes #320

Closed manulera closed 1 week ago

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.63%. Comparing base (989e76e) to head (f060730). Report is 2 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/BjornFJohansson/pydna/pull/320/graphs/tree.svg?width=650&height=150&src=pr&token=8gKFpo7HAl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bj%C3%B6rn+Johansson)](https://app.codecov.io/gh/BjornFJohansson/pydna/pull/320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bj%C3%B6rn+Johansson) ```diff @@ Coverage Diff @@ ## master #320 +/- ## ========================================== + Coverage 93.00% 93.63% +0.63% ========================================== Files 40 40 Lines 3744 3926 +182 Branches 562 589 +27 ========================================== + Hits 3482 3676 +194 + Misses 217 198 -19 - Partials 45 52 +7 ``` | [Files with missing lines](https://app.codecov.io/gh/BjornFJohansson/pydna/pull/320?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bj%C3%B6rn+Johansson) | Coverage Δ | | |---|---|---| | [src/pydna/amplify.py](https://app.codecov.io/gh/BjornFJohansson/pydna/pull/320?src=pr&el=tree&filepath=src%2Fpydna%2Famplify.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bj%C3%B6rn+Johansson#diff-c3JjL3B5ZG5hL2FtcGxpZnkucHk=) | `98.67% <100.00%> (+0.01%)` | :arrow_up: | | [src/pydna/tm.py](https://app.codecov.io/gh/BjornFJohansson/pydna/pull/320?src=pr&el=tree&filepath=src%2Fpydna%2Ftm.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bj%C3%B6rn+Johansson#diff-c3JjL3B5ZG5hL3RtLnB5) | `96.92% <100.00%> (-3.08%)` | :arrow_down: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/BjornFJohansson/pydna/pull/320/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bj%C3%B6rn+Johansson)
manulera commented 4 weeks ago

Hi @BjornFJohansson this is a small fix of the icon link. Because it's to the master branch it requires your approval

manulera commented 2 weeks ago

I added a few small fixes:

324

325

326

BjornFJohansson commented 1 week ago

Do we merge?

manulera commented 1 week ago

@BjornFJohansson can you make a pre-release for pypi?