Can't inline script such as `const x = '</script>'`

[seiyab]

Hi. Trying to this interesting and useful plugin, I found inlining scripts that contains </script> enexpectedly closes script tag.

Adding a context, I'm trying to bundle React application into a single HTML. React (probably react-dom) contains div.innerHTML = "<script></script>";, at least as of 18.2.0.

[seiyab]

html-inline-script-webpack-plugin probably handles it like this:

(asset.source() as string).replace(/(<)(\/script>)/g, '\\x3C$2')

https://github.com/icelam/html-inline-script-webpack-plugin/blob/fd19ece98f3f1b13a02a61dd481f50b31cb8945d/src/HtmlInlineScriptPlugin.ts#L98

[BjornTheProgrammer]

Would you be willing to make a minimum reproducible example of this bug?

[seiyab]

OK, I will. Which do you prefer?

• Really minimal one that makes sence little.
  • e.g. window.alert("</script>")
• More practical one
  • e.g. bundling React

[BjornTheProgrammer]

The more practical one with a minimal React example. Also, note that the code has been significantly reworked in v1.3.1, so try upgrading first.

[seiyab]

Here is. https://github.com/seiyab/repro/tree/main/bun-plugin-html-inline

[BjornTheProgrammer]

@seiyab this should now be fixed as of v1.3.2. Thank you for your bug report! Let me know if you have any other issues.

[seiyab]

I confirmed v1.3.2 works fine 👍 🎉 🥇