search

Bjornej / GruntLauncher

A vspackage that adds the possibility to launch Grunt tasks
MIT License
40 stars 11 forks source link

- Fixed issue #26: Require not working to resolve actual path, yo u get ... #29

Closed martin-s closed 9 years ago

martin-s commented 9 years ago

Fix for issue #26

Bjornej commented 9 years ago

Hi. Thanks for the pull request.

The solution is ok but when I tried it I noticed a 4-5 seconds delay when opening the solution explorer contextual menu maybe due to starting the process on the command line.

Does this also happen to you?

martin-s commented 9 years ago

Ok, I will test it regarding performance. Maybe we'll have to do a pre-processing for process execution. What would be a suitable initialisation point for the extension?

Current delay in opening context menu is about 1.5s, in case of fallback mechanism (process execution). To optimize this, we could save the task list and update it by clicking on "Cannot parse Gruntfile". Wdyt?

Bjornej commented 9 years ago

Thanks for the further testing.

I'll merge the pull request and change the current cache by saving the task list along with the last modified date of the gruntfile so without changes we can simply reuse the previous results.

I have an idea about reducing the time by avoiding the console process and invoking directly grunt with edge.js. I'll see if it reduces the first execution time a little

CKGrafico commented 9 years ago

Where can I find the .vsix file with this solved?

Bjornej commented 9 years ago

Hi it's hasn't still been published to the visuastudiogallery as I was trying to speed it up by using edge.js instead of a commandline process.

In the meantime if you need this functionality you can install this test version

CKGrafico commented 9 years ago

Perfect! Thanks