search

Bl4Cc4t / GoodTwitter2

Userscript to modify the looks of twitter.com
489 stars 64 forks source link

Gap when logged out and fixed sidebars enabled #138

Closed spodermenpls closed 4 years ago

spodermenpls commented 4 years ago

Please check the following before you continue

Describe the bug As mentioned in #135, having "Show trends on left sidebar" and "Show always 10 trends" activated only gets enforced/honored while being logged-out, while being logged-in, the "Trends" section only contains the title on a white canvas, with no actual trends underneath it, and still being on the right hand side.

On a side note, as this probably doesn't merit an extra issue: activating "Fixed sidebars" leads to a big gap between the center and right sidebar, while being logged-out (as seen on screen 2).

Screenshots Settings: einst

While logged-out: loggedout

While logged-in: loggedin

Your configuation

Bl4Cc4t commented 4 years ago

I cannot reproduce this behavior. Have you tried reinstalling the script? Does it work if you disable all other extensions? What happens when you disable TM, reload and the enable it again and reload?

I also noticed that some places (e.g. smaller countries) have zero trends showing up and that looks just like that (even the cog is missing)

spodermenpls commented 4 years ago

Over night (with no changes on my part) the trends section at least moved to the left sidebar: lefthand I'll try your recommendations, give me a minute. I'll also try the latest VM Release Candidate, the "undefined-> GET" issue gets solved by it, for example.

That may be true, but doesn't apply here, since it displays nothing else but German trends (and the cog is also back).

spodermenpls commented 4 years ago

Okay, this seems to have solved itself, I assume from switching back and forth between the "Raw export" workaround from Issue 135 and the official script lots of times and repeated deleting of cookies and storage, the checkbox in the "trend" settings wasn't ticked anymore, leading to no trends being displays at all; now being ticked again, it displays "Trends: Germany" as it should. I have no idea where the sudden mood change concerning the right/left sidebar stems from, though..

The only thing remaining is the gap while logged-out, apparently. 😄 I checked the latest VM RC, it doesn't seem to change the functionality of this userscript for the worse or the better, as far as I can tell.

Bl4Cc4t commented 4 years ago

I'll also try the latest VM Release Candidate, the "undefined-> GET" issue gets solved by it, for example.

Ah, that’s nice :D

Okay, this seems to have solved itself, I assume from switching back and forth between the "Raw export" workaround from Issue 135 and the official script lots of times and repeated deleting of cookies and storage, the checkbox in the "trend" settings wasn't ticked anymore, leading to no trends being displays at all; now being ticked again, it displays "Trends: Germany" as it should. I have no idea where the sudden mood change concerning the right/left sidebar stems from, though..

Hm, that I can’t do much about. Glad it works now!

The only thing remaining is the gap while logged-out, apparently.

The gap will be corrected soon. I don’t use twitter logged out, so I don’t stumble upon such issues that easily :/