search

Bl4Cc4t / GoodTwitter2

Userscript to modify the looks of twitter.com
496 stars 63 forks source link

legacy nav bar on profiles has extra parameters that break visibility #251

Open dollhaus opened 3 years ago

dollhaus commented 3 years ago

the div gt2-legacy-profile-nav-right has a few extra parameters applied to it after the page loads, or about five seconds after removing them. GT2 needs to (I think) monitor the div and remove the extra params whenever they've been added. Capture

This is what happens with the extra two params:

Capture

This is what happens when those params are removed:

Capture

Bl4Cc4t commented 3 years ago

I can see that you're using Firefox but I don't know what version and I can only guess if you're using VM or TM. I'm not sure why that happens so often, but please do not remove the template for bugs! It has a purpose, I cannot magically know what specific versions of what you're using.

With that said, I cannot reproduce this bug on Firefox with neither TM nor VM (all on their latest versions). Do you have any settings in GT2 activated (aside from the legacy profile layout)? Does it happen with all other add-ons deactivated (except your script manager)?

This is a behavior I have not seen before, I'm curious why it happens.

dollhaus commented 3 years ago

There's a template? I'm sorry, I don't see one.

So far, this occurs under Chromium 62.0.3202.94 and FF 69.0.2, with Tampermonkey. That's on both Fedora and Windows, although W7 was running in a VM. Windows has uBlock enabled, and under Linux disabing uBlock and Decetraleyes makes no difference.

I was playing around with some logging, and I think it's something to do with React being fussy about something. I don't understand that much about React, but I'll keep digging.

Here is a snap of the settings I have enabled:

Capture

dollhaus commented 3 years ago

Oh, I found the template. One of my uBlock rules disables pre-filling textboxes as a precautionary measure.

Bl4Cc4t commented 3 years ago

Hm, still no luck. I downloaded Chromium 62.0.3202.0 and enabled all the settings in GT2, even installed uBlock and the other extension. I don't get this issue... I have no idea why this is.

I doubt it has to do with the OS' you're using, that doesn't make sense. Although the browser versions you're using are about 3 years old, the changes in their JS engines are not that significant to the script. Have you tried using a newer version of Chrome/FF? I wonder if that changes anything.

It could be based on your location - Twitter usually rolls out changes (that sometimes break my script) at different times for each region (maybe country based?).

Enduser-only commented 3 years ago

I had the same problem while also on firefox. I was also using the uBlock origin add-on and when I disabled cosmetic filtering on Ublock origin the nav bar re-appeared while using the legacy profile layout.