Bl4Cc4t / GoodTwitter2

Userscript to modify the looks of twitter.com
489 stars 64 forks source link

More white buttons #272

Closed MistressAshai closed 3 years ago

MistressAshai commented 3 years ago

Same issue from #266

On certain accounts, the entire button instead of just the border is white. rOcqkq

The "Edit Profile" button wasn't fixed GemWdC

Bl4Cc4t commented 3 years ago

Thanks for noticing these. Looks like I forgot the edit button... I don't know why the follow buttons would be filled white sometimes. Twitter's design decisions are very weird and make not much sense to me. Since I do not have the "Topics to follow" section, could you please test if they disappear or change in some way once you click follow?

Also, if you are using Tampermonkey, you can test the rules I just added by doing the following: 1. On [Twitter](https://twitter.com), click on the TM icon 1. Click on the plus next to the script name to expand it. 1. Click on "Edit" ![image](https://user-images.githubusercontent.com/6740726/112702004-6f621380-8e92-11eb-9974-dc9301691459.png) 1. Click on the tab "Externals" 1. Under Resources, click on "Edit" for the `.css` file ![image](https://user-images.githubusercontent.com/6740726/112702112-be0fad80-8e92-11eb-996d-8fba5c1c62e3.png) 1. Open [this link](https://gist.githubusercontent.com/Bl4Cc4t/727ebc230fe1e37b28d703ae496a2641/raw/74350d046c2712f7c17bf1090f1e9268a9d7c70e/gt2-css-2021-03-27) and copy the contents of that page into the text field of the editor. 1. Press Ctrl+S to save the file 1. Check if the buttons look like they should 1. Once you're done, please click on the delete button next to the edit button from step 5. If you don't do that, any future updates to the script won't get applied for that file.
MistressAshai commented 3 years ago

When clicking follow on "Topics to Follow", it removes the white background.

image

After trying the new rules, everything seems to work as intended! image

But it seems like clicking follow on "Who to follow", makes the background white until the mouse is no longer hovering the button.

image

Bl4Cc4t commented 3 years ago

Hm okay... To fix that, I need your help again. Can you please to the following:

  1. Right click a follow button and choose "Inspect"
  2. Navigate in the element tree to the button element, it should look similar to this: image
  3. Make a screenshot of that, like I did above
  4. Open the screenshot and put the window side by side with your browser
  5. Click on the inspected button and stay with your mouse on it.
  6. Compare the values in the classes sections, there should be an additional one now
  7. Post the class name here.

I usually do not use these classes, since they are not really reliable to work with (they could change at any time), but for this occasion, there is sadly no other way to change the color as far as I know.

Thanks for helping me tackle this down, I cannot do it myself since I don't have this change yet. I noticed that Twitter changes are often rolled out with some delay depending on where you live.

MistressAshai commented 3 years ago

Looks like the class name is "r-1gg85qh", replacing "r-14lw9ot".

Here are the screenshots just in case I read it wrong.

Before image

After image

Bl4Cc4t commented 3 years ago

Okay, to confirm it works, can you please try changing the css again?

MistressAshai commented 3 years ago

This edit does get rid of the white, but also gets rid of the red border and background of the button when trying to unfollow.

Bl4Cc4t commented 3 years ago

Could you make a screenshot of that? And if possibly post, what class the button has that makes it red. It should be pretty high up in the list. image

Bl4Cc4t commented 3 years ago

I hope this works for all users that have these strange white suggestions since I can't even use the classes you provided on my end.

MistressAshai commented 3 years ago

Seems like it IS "r-1ucxkr8", like in your screenshot, that makes the background color red, but the css you had me test overwrites it.

image image

Bl4Cc4t commented 3 years ago

Oh, that only happens to the topics to follow buttons...? I didn't know that. I hope this one works now :D

Bl4Cc4t commented 3 years ago

Any update? @MistressAshai

MistressAshai commented 3 years ago

Oh, sorry! Yeah it seems to work now!

image

Bl4Cc4t commented 3 years ago

okay, nice

Bl4Cc4t commented 3 years ago

Twitter seems to have added the colors back in. So, everything can be deleted again :/