search

BlaNKtext / webosu

The unofficial osu! web port with a huge pool of beatmaps
https://webosu.online
MIT License
63 stars 33 forks source link

Change API to osu.direct #9

Closed notadev01 closed 2 months ago

notadev01 commented 2 months ago

Fixes #8, and since osu.direct is much faster and reliable, it fixes those issues too.

The only thing I didn't change to osu.direct was the audio preview. osu.direct asks for a map ID directly, and not a set ID + an index, and I don't know enough about this project to fix that myself.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webosu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2024 11:56pm
Philenst commented 2 months ago

You clearly have no insight into osu mirrors if you think that osu.direct is "faster and more reliable" than Mino. Feel free to try it yourself. I presume you are based in the US to state this, as this is the only place that osu.direct has a server, Mino has servers in US, EU, SA, AS, you can check the performance yourself on https://catboy.best/compare, would love to see your results.

image

image

If you actually read the code, you'd see that the issue you're refencing is not an issue with Mino, however with how webosu queries for beatmaps, this code is actually on the lines you edited for this PR, therefore I'd recommend you read them.

Calemy commented 2 months ago

whatever @Philenst said. Won't make the change because it essentially solves nothing and not only that, most likely introduces worse performance and more downtime for webosu. Thank you for your try!