search

BlacKCaT27 / CurrencyEditText

A module designed to encapsulate the use of an Android EditText field for gathering currency information from a user. Supports all ISO-3166 compliant locales/currencies.
Apache License 2.0
339 stars 79 forks source link

Poland currency issue #20

Closed LucasEduardo closed 7 years ago

LucasEduardo commented 8 years ago

For Poland there is an issue because the currency simbol has 2 characters (for euro it is only 1). The code was coming from right to left 2 characters, the euro simbol and the space. I already fixed for my application and I'm going to do a pull request for this fix today.

BlacKCaT27 commented 8 years ago

Thanks for looking into that! The code that's there now could definitely use some polish (hah!). It was one of those "It works for now" pieces I just haven't gotten back to. Looking forward to the pull request. Please try to get a unit test or two around it as well, if you don't mind.

On Aug 5, 2016 5:26 PM, "LucasEduardo" notifications@github.com wrote:

For Poland there is an issue because the currency simbol has 2 characters (for euro it is only 1). The code was coming from right to left 2 characters, the euro simbol and the space. I already fixed for my application and I'm going to do a pull request for this fix today.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BlacKCaT27/CurrencyEditText/issues/20, or mute the thread https://github.com/notifications/unsubscribe-auth/AE_54U2C7x98nfMeugtUkudVKAXY6hCmks5qc6pzgaJpZM4JeEt7 .

BlacKCaT27 commented 7 years ago

I left you a note on your pull request but I'm adding it here as well:

Your proposed fix was great and I've included it in v2.0 of the library. I added the fix manually as I was right in the midst of a decently large refactoring and your fix was simple and straight-forward. I've credited you in the comments :)

LucasEduardo commented 7 years ago

That's great! Thank you! :)

-- Lucas Eduardo

2017-07-09 3:23 GMT-03:00 Josh Kitchens notifications@github.com:

I left you a note on your pull request but I'm adding it here as well:

Your proposed fix was great and I've included it in v2.0 of the library. I added the fix manually as I was right in the midst of a decently large refactoring and your fix was simple and straight-forward. I've credited you in the comments :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BlacKCaT27/CurrencyEditText/issues/20#issuecomment-313901853, or mute the thread https://github.com/notifications/unsubscribe-auth/AFfWTcK-AWz9oKXGIOXDotbk3cDx0i-0ks5sMHHHgaJpZM4JeEt7 .