search

Black-Wyrm-Lair / WTPFamiliars

Enhanced-edition-compatible version of Rabain/Salk's expanded familiar mod
1 stars 2 forks source link

Pseudodragon/Imp magic resistance glitch #1

Open flamewing opened 6 years ago

flamewing commented 6 years ago

When a player with magic resistance (for example, from an amulet) first summons the familiar, sometimes the magic resistance will increase continuously until it hits 127.

Salk73 commented 4 years ago

@flamewing ,

could you tell me a little more about this bug? Can you reproduce it consistently? I'm not sure when I can take a look at it but I may have some time by the end of the month and I would like to be rid of any confirmed bug in my code.

flamewing commented 4 years ago

I have to see if it still happens, and try to reproduce; back when I ran into this, I was toying with making an angel-like character for BG2EE that used non-removable 1PP wings with a circlet inventory appearance (a halo), and this halo gave magic resistance. I summoned a pseudo-dragon familiar with this character, and when I looked at the character page, the magic resistance was at 127. I am not sure what went wrong, and I never had the time to debug much; but when I summoned the pseudo-dragon before putting on the circlet, everything went fine.

Salk73 commented 4 years ago

Okay, thanks... Looking at the code I don't actually see how that could happen since #GMR_Active should stop the bonus from being applied more than once. I remember testing this at the very beginning of ToB using the Bioware mage which wears some item that boosts magic resistance and I don't remember seeing this problem but it may have escaped my attention.

It may have to do with the level up process interfering with the correct application of the bonus. If that is the case, it'd just be a matter of adding an extra conditional check to make sure no bonus is applied until the level up is completed.

WeareTheDraiken commented 2 months ago

@Salk73 This issue is still present in the current 2.7 version that is compatible with EET. Did you ever get to being able to devise how to add the conditional check?

WeareTheDraiken commented 1 month ago

Solved with an edit on my page.